add changelog entry for Dockerfile USER_GID as non root #11829
Conversation
Co-authored-by: Yang Song <[email protected]>
| change_type: 'enhancement' | ||
|
|
||
| # The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver) | ||
| component: container |
There was a problem hiding this comment.
There is no container component in this repo, maybe use release or image instead
There was a problem hiding this comment.
Thanks! Replaced in 9593eba
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11829 +/- ##
=======================================
Coverage 91.58% 91.58%
=======================================
Files 445 445
Lines 23737 23737
=======================================
Hits 21739 21739
Misses 1623 1623
Partials 375 375 ☔ View full report in Codecov by Sentry. |
| component: image | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: "Set Dockerfile's USER_GID as non root. OpenTelemetry Collector releases issue: https://github.com/open-telemetry/opentelemetry-collector-releases/issues/662" |
There was a problem hiding this comment.
[nitpick] can you not add the link to the issues: field below?
There was a problem hiding this comment.
no, you can only link issues / PRs in this repo in issues:
|
You can add to the changelog of the release on opentelemetry-collector-releases, I don't think the opentelemetry-collector is the right place for this change entry. |
|
I agree with Antoine, I think this change should be noted in the opentelemetry-collector-releases repository instead of here |
|
agree if we can changelog to the -releases repo, that would be more ideal |
|
Changelog is in -releases now! |
|
Sounds good to me as well. The primary reason for adding the changelog entry in the collector's repository was to ensure visibility, particularly for environments that might be impacted. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description
This PR just adds a new changelog entry for the changes we are doing in the releases repository: open-telemetry/opentelemetry-collector-releases#738
The main reason is that the
releasesrepository does not have any changelog mechanism, but the corresponding change is important enough to make the users aware of.My understanding is that this PR should be merged after open-telemetry/opentelemetry-collector-releases#738 but before its next release
Link to tracking issue
Fixes
open-telemetry/opentelemetry-collector-releases#662